UI: Fix duplicate quickview (for provider column) in backup repository by sureshanaparti · Pull Request #11849 · apache/cloudstack

sureshanaparti · 2025-10-16T10:05:08Z

Description

This PR fixes duplicate quickview (for provider column) in backup repository, and consolidates the existing quickview for first column, column key.

Quickview for provider column is enabled for OAuth providers only, here: https://github.com/apache/cloudstack/pull/7996/files#diff-fa50e9f30df1f49ab46e9e30d15009ff36b166ce26cb289a8ec75a4f60873d2b

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Primarily verified quick views for the below sections in UI, randomly checked few other sections as well.

Infrastructure->Backup Repository (first column - Name)
Configuration->OAuth Configuration (first column - Provider)
Compute->Instance Snapshots (first column - Display name)
Storage->Snapshot policies (first column - Interval type)
Configuration->Guest OS mappings (first column - Hypervisor)
Tools->Webhooks (first column - Name)

Backup Repository UI, Before Fix:

Backup Repository UI, After Fix:

OAuth Configuration UI, No change:

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-10-16T10:06:11Z

@blueorangutan ui

blueorangutan · 2025-10-16T10:07:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2025-10-16T10:13:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.92%. Comparing base (a1bcae9) to head (006ae64).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11849      +/-   ##
============================================
- Coverage     17.92%   17.92%   -0.01%     
  Complexity    16154    16154              
============================================
  Files          5939     5939              
  Lines        533151   533151              
  Branches      65228    65229       +1     
============================================
- Hits          95585    95583       -2     
  Misses       426827   426827              
- Partials      10739    10741       +2

Flag	Coverage Δ
uitests	`3.66% <ø> (-0.01%)`	⬇️
unittests	`19.03% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-10-16T10:29:06Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11849 (QA-JID-778)

sureshanaparti · 2025-10-16T15:23:01Z

@DaanHoogland that will enable quick view only in oauthsetting, for provider column. all other views have name column and route is not oauthsetting.

name column is the usual quick view column, only exception is provider column (used in oauthsetting for quick view)

DaanHoogland · 2025-10-17T07:52:52Z

@DaanHoogland that will enable quick view only in oauthsetting, for provider column. all other views have name column and route is not oauthsetting.

name column is the usual quick view column, only exception is provider column (used in oauthsetting for quick view)

Thanks @sureshanaparti , I had found my erroneous way of thinking and deleted my comment.

abh1sar

Hi Suresh,
Please see if the suggested change make sense.
The idea is to show the quick view only on the first column if it is one of [name, provider].
I think this is consistent with the existing UI behaviour and the code seems more maintainable.

ui/src/components/view/ListView.vue

sureshanaparti · 2025-10-29T08:39:49Z

@blueorangutan ui

blueorangutan · 2025-10-29T08:41:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-10-29T09:00:58Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11849 (QA-JID-784)

abh1sar

@sureshanaparti The provider column was still showing the quick view with these changes in backup repository.

I have suggested a change in quickViewEnabled(). Can we keep the check that the column has to be the first column? Also can we remove all checks regarding column names (name, provider, hypervisor etc)? These are already being checked before calling quickViewEnabled in the parent elements.

ui/src/components/view/ListView.vue

github-actions · 2026-01-05T08:25:51Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

harikrishna-patnala · 2026-01-29T06:26:23Z

@sureshanaparti can you please resolve the conflicts and review Abhisar's suggestion.

sureshanaparti · 2026-02-02T18:39:30Z

@blueorangutan ui

blueorangutan · 2026-02-02T18:40:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

sureshanaparti · 2026-02-02T18:53:49Z

@blueorangutan ui

blueorangutan · 2026-02-02T18:55:03Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-02-02T19:02:45Z

UI build failed: ✖️
(SL-JID-869)

blueorangutan · 2026-02-02T19:18:28Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11849 (QA-JID-870)

abh1sar

LGTM. tested some of the impacted routes. Quick view action is only displayed on the first column as expected.

boring-cyborg bot added the component:UI label Oct 16, 2025

sureshanaparti requested a review from harikrishna-patnala October 16, 2025 10:07

sureshanaparti requested a review from vishesh92 October 16, 2025 10:07

sureshanaparti closed this Oct 16, 2025

sureshanaparti reopened this Oct 16, 2025

sureshanaparti requested a review from abh1sar October 16, 2025 11:42

sureshanaparti closed this Oct 16, 2025

sureshanaparti reopened this Oct 16, 2025

sureshanaparti force-pushed the ui-backup-repo-quickview-fix branch from 235d726 to 8e0dc34 Compare October 17, 2025 04:02

abh1sar suggested changes Oct 22, 2025

View reviewed changes

ui/src/components/view/ListView.vue Outdated Show resolved Hide resolved

ui/src/components/view/ListView.vue Outdated Show resolved Hide resolved

sureshanaparti force-pushed the ui-backup-repo-quickview-fix branch 2 times, most recently from d0a5207 to ac63e7e Compare October 29, 2025 08:38

abh1sar reviewed Oct 30, 2025

View reviewed changes

ui/src/components/view/ListView.vue Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Jan 5, 2026

DaanHoogland added this to the 4.23.0 milestone Jan 29, 2026

sureshanaparti force-pushed the ui-backup-repo-quickview-fix branch from ac63e7e to a10235b Compare February 2, 2026 18:39

github-actions bot removed the status:has-conflicts label Feb 2, 2026

sureshanaparti requested a review from abh1sar February 2, 2026 18:41

sureshanaparti added the status:needs-testing label Feb 2, 2026

sureshanaparti force-pushed the ui-backup-repo-quickview-fix branch from a10235b to d2f10ce Compare February 2, 2026 18:53

abh1sar approved these changes Feb 6, 2026

View reviewed changes

sureshanaparti added 3 commits February 18, 2026 00:37

UI: Fix quickview (for provider column) in backup repository

8872732

Consolidated quickview checks with first column, column key

17f3710

quickViewEnabled condition update

006ae64

sureshanaparti force-pushed the ui-backup-repo-quickview-fix branch from d2f10ce to 006ae64 Compare February 17, 2026 19:07

Conversation

sureshanaparti commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Oct 16, 2025

Uh oh!

blueorangutan commented Oct 16, 2025

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 16, 2025

Uh oh!

sureshanaparti commented Oct 16, 2025

Uh oh!

DaanHoogland commented Oct 17, 2025

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Oct 29, 2025

Uh oh!

blueorangutan commented Oct 29, 2025

Uh oh!

blueorangutan commented Oct 29, 2025

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

harikrishna-patnala commented Jan 29, 2026

Uh oh!

sureshanaparti commented Feb 2, 2026

Uh oh!

blueorangutan commented Feb 2, 2026

Uh oh!

sureshanaparti commented Feb 2, 2026

Uh oh!

blueorangutan commented Feb 2, 2026

Uh oh!

blueorangutan commented Feb 2, 2026

Uh oh!

blueorangutan commented Feb 2, 2026

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sureshanaparti commented Oct 16, 2025 •

edited

Loading

codecov bot commented Oct 16, 2025 •

edited

Loading